[demo only] CI integraton and fixes #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update integration test to actually fail (exit with non-zero status code) when there is a problem
domdomegg
force-pushed
the
ci-integraton-and-fixes
branch
from
606d5be to
c7ed51c
Compare
domdomegg
force-pushed
the
ci-integraton-and-fixes
branch
from
c7ed51c to
156073a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual PRs here:
This shows all of them combined, demonstrating how the fixes make all the integration tests pass. This is just to demonstrate the passing integration tests - I'd expect comments on the individual PRs and for them to be merged independently.